[Website] Update deps #449
Conversation
| "jquery": "^3.5.1", | ||
| "popper.js": "^1.16.1", | ||
| "webpack": "^5.76.0", | ||
| "bootstrap": "^5.3.2", |
There was a problem hiding this comment.
Updating Bootstrap 4 -> 5 may break design. Could you check it?
There was a problem hiding this comment.
It seems ok. Most of the documentation is built in the other Arrow repositories.
There was a problem hiding this comment.
Could you share what you checked?
This PR also updates jekyll-feed. So we need to check at least https://arrow.apache.org/feed.xml too.
There was a problem hiding this comment.
Providing preview is also helpful.
See also: https://github.com/apache/arrow-site#forks
There was a problem hiding this comment.
The current preview workflow at https://github.com/apache/arrow-site/blob/main/.github/workflows/deploy.yml fails with newer Jekyll as the one used by GitHub is older.
The current site can be previewed at https://bkmgit.github.io/arrow-site - without changes
Associated workflow is at:
https://github.com/bkmgit/arrow-site/blob/bkmgit-patch-1/.github/workflows/preview.yml
Can make a pull request to add this so that creating preview sites is easier.
- It does not download the crossbow artifacts, though can add these if they are helpful
- One would need to change permissions to enable deployment, see https://stackoverflow.com/questions/76937061/branch-master-is-not-allowed-to-deploy-to-github-pages-due-to-environment-prot
- If the preview site is created within a subfolder of https://apache.github.io/arrow-site/ say https://apache.github.io/arrow-site/preview/2024-01-06-12-30 then a cron job can be used to remove the preview but having the preview hosted from the origin of the pull request seems sufficient. Just need to document what to do.
There was a problem hiding this comment.
The former isn't problem because we have 2 posts on 2023-11-09.
The latter will be fixed by the following. Could you send a separated PR?
diff --git a/_posts/2023-08-05-datafusion_fast_grouping.md b/_posts/2023-08-05-datafusion_fast_grouping.md
index f8b5a50e5ef..57fc1b70d87 100644
--- a/_posts/2023-08-05-datafusion_fast_grouping.md
+++ b/_posts/2023-08-05-datafusion_fast_grouping.md
@@ -25,7 +25,7 @@ limitations under the License.
{% endcomment %}
-->
-<!--- Converted from Google Docs using https://www.buymeacoffee.com/docstomarkdown --->
+<!-- Converted from Google Docs using https://www.buymeacoffee.com/docstomarkdown -->
## Aggregating Millions of Groups Fast in Apache Arrow DataFusion
There was a problem hiding this comment.
The preview site has <meta name="generator" content="Jekyll v4.2.0" />.
Is it really generated with Jekyll 4.3.3?
There was a problem hiding this comment.
PR to fix rss #461
Thanks, had served pages from incorrect directory. Needed to add base_url to config to
get correct urls in the preview. Using environment variables seems to repeat the base_url
so have put this in the extra_config.yml file
Preview at https://bkmgit.github.io/arrow-site/
There was a problem hiding this comment.
Need to check navbar, other things seem to work.
There was a problem hiding this comment.
@kou Dropdowns work now. Let me know if anything else is needed.
bkmgit
force-pushed
the
Update-deps
branch
11 times, most recently
from
305e341
to
e04f961
Compare
|
A few things I noticed on the preview: 1. The labels on blog posts have a wrong color that make them invisible (https://bkmgit.github.io/arrow-site/blog/2023/12/18/14.0.2-release/):
versus (https://arrow.apache.org/blog/2023/12/18/14.0.2-release/):
2. The last dropdown (ASF links) is too close to the border of the window such that it slightly falls off:
versus:
It seems that the navbar no longer has left/right padding in the updated bootstrap (also the logo on the left side is closer to the side) 3. On the landing page, the top bar is now a slightly darker grey than the the background of the big logo banner, while before this was they same color (so you didn't visually distinguish the navbar on the landing page from the big banner). Is that change intentional? 4. In the mobile layout, the navigation doesn't work (clicking the "hamburger" menu doesn't do anything for me): |
bkmgit
force-pushed
the
Update-deps
branch
9 times, most recently
from
b8310ec
to
49f7863
Compare
|
@jorisvandenbossche Thanks for the feedback.
Other suggestions are welcome. Site can be previewed at: |
|
@jorisvandenbossche In the upgraded version all hyperlinks are underlined, otherwise it seems quite similar. Can figure out how to remove the underlines in hyperlinks. |
bkmgit
force-pushed
the
Update-deps
branch
2 times, most recently
from
a26d037
to
50ed23e
Compare
Put base url in Jekyll config to ensure rss feed has correct path Popper needs to be explicitly imported Bootstrap5 bg-dark color has changed, so need to match landing page title background color Bootstrap5 underlines links by default, use css not to underline links unless hovered over Bootstrap 4 -> 5 migration Replace data-toggle by data-bs-toggle Replace mr- by me- Replace right- by end- Put a container round navbar Replace badge-secondary by bg-secondary Replace ml-auto by ms-auto Specify bootstrap javascript requirements
No description provided.