Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-31412: [Website] Remove support for triggering GitHub Actions apache/arrow-site website deployment workflow when pushing to master #323

Merged
merged 1 commit into from Mar 1, 2023

Conversation

kevingurney
Copy link
Member

@kevingurney kevingurney commented Feb 28, 2023

Overview

As part of apache/arrow#31142 and in response to the recent rename of the apache/arrow-site repository default branch to main, this pull request removes support for triggering the website deployment workflow (.github/workflows/deploy.yml) on pushes to a branch with the name "master".

Qualification

To qualify these changes, I verified that:

  1. Pushing these changes to the main branch of mathworks/arrow-site triggered the deploy.yml workflow as expected.
  2. The workflow step "Configure for GitHub Pages on push to main or master branch" has been renamed to "Configure for GitHub Pages on push to main branch"
  3. The deploy.yml is no longer being triggered when commits are pushed to a branch named "master".

Future Directions

  1. I will follow up with a separate PR to address [Website] Remove mentions of master branch from Apache Arrow website content arrow#20161

Notes

Note: The CI failures in the Build step are unrelated to this change. This is a result of #325, which is being addressed separately.

Closes apache/arrow#31412.

@kevingurney
Copy link
Member Author

I don't think I have the permissions to change it, but I think apache/arrow#31412 should be part of the [Website] component rather than the [Dev] component.

@kevingurney
Copy link
Member Author

@jorisvandenbossche would you be willing to review this PR? Thank you!

@kevingurney
Copy link
Member Author

Note: The CI failures in the Build step are unrelated to this change. This is a result of #325, which is being addressed separately.

@kou kou changed the title GH-31412: [Dev] Remove support for triggering GitHub Actions apache/arrow-site website deployment workflow when pushing to master GH-31412: [Website] Remove support for triggering GitHub Actions apache/arrow-site website deployment workflow when pushing to master Mar 1, 2023
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou merged commit 26c92c9 into apache:main Mar 1, 2023
@kevingurney kevingurney deleted the GH-31412 branch March 1, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants