Add additional WriteMultipart tests (#5743) #5746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
May 10, 2024
|
|
||
| let chunks = chunks.lock(); | ||
|
|
||
| let actual: Vec<_> = chunks.iter().flatten().flatten().copied().collect(); |
There was a problem hiding this comment.
Could we also please add a check here that the chunks are actually the expected sizes? I am imagining what if new_with_chunk_size didn't actually cause multiple chunks to be written?
There was a problem hiding this comment.
There is a check for this two lines below?
There was a problem hiding this comment.
Yes you are right -- sorry I missed that
I was thinking that for chunk in chunks.iter().take(chunks.len() - 1) { would work even if there were only one chunk. However, I see now that assert_eq!(chunk.content_length(), chunk_size) verifies that each chunk is exactly chunk_size bytes so if for example new_with_chunks_size hadn't worked, this assert would fail
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #5743
Rationale for this change
It makes me rather uncomfortable that #5743 managed to slip through our testing coverage. Therefore this PR further extends the test coverage, beyond the limited tests added in #5744.
What changes are included in this PR?
Are there any user-facing changes?