Deprecate NaiveDateTime #5684
Draft
Deprecate NaiveDateTime #5684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to use DateTime<Utc>
Any test call-site is updated for DateTime<Utc>. However, normal code call-sites immediately convert back to naive datetime. I'm currently uncertain about the post-migration apis of the following: - [`arrow_cast::cast::adjust_timestamp_to_timezone`] - [`arrow_array::array::`PrimitivieArray<t>::value_as_datetime`] - [`arrow_array::types::ArrowTimestampTime::make_value`]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #5480.
What changes are included in this PR?
Migration of
arrow_array::temporal_conversion::as_datetime(and delegated functions) toDateTime<Utc>Are there any user-facing changes?
Yes, all the temporal conversions use
DateTime<Utc>.NOTES
Other call-sites for
as_datetimecurrently convert immediately back to the naive version. I thought this was a good jumping off point to make sure this is in the right direction.I'm also uncertain on what the final goal state should look like, especially regarding these three signatures.
arrow_cast::cast::adjust_timestamp_to_timezone]arrow_array::array::PrimitivieArray<t>::value_as_datetime]arrow_array::types::ArrowTimestampTime::make_value]If I'm on the right track, I'd much appreciate any guidance on what the next push should look like.