Use ScalarBuffer<u8> instead of Buffer for FixedSizeBinaryArray
#5667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure about this, GenericByteArray and friends also use Buffer for raw bytes, which ultimately is what Buffer is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Prefer the strongly-typed
ScalarBufferover the untypedBuffer. It helps when trying to construct this array from other typed buffers likeVec<u8>because this conversion is not directly supported forBuffer(because of #3756 (comment)).What changes are included in this PR?
Changed
value_datafield ofFixedSizeBinaryArrayfromBuffertoScalarBuffer<u8>.Are there any user-facing changes?
FixedSizeBinaryArraynew/try_newandinto_partsnow useScalarBufferinstead ofBuffer.This is a breaking change.