Add coerce_types flag to parquet WriterProperties (#1938) #5640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getChan
force-pushed
the
parquet-coerce-types
branch
from
27b8386
to
42322f8
Compare
|
This doesn't appear to hook up the parameter to perform the conversions as described on the ticket? |
|
Marking as draft as not currently waiting on review, feel free to unmark when you would like me to take another look |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1938.
Rationale for this change
Add a coerce_types flag that will use the arrow cast kernels to coerce incompatible types prior to writing them