Add test for equality on slices of a struct array #555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjchambers
changed the title
bjchambers
force-pushed
the
struct-slice-equality
branch
from
16db65a
to
60190ad
Compare
|
Marking PRs that are over a month old as stale -- please let us know if there is additional work planned or if we should close them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #514.
Rationale for this change
This was caused by a problem in struct slices and equality. It was fixed by a separate PR, but it seems beneficial to get an explicit test of the expected behavior in as well to prevent regression.
What changes are included in this PR?
A test that was previously failing for equality on slices of a struct array.
Are there any user-facing changes?
No.