Add DictionaryArray::occupancy #4415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Jun 15, 2023
| let len = self.values.len(); | ||
| let mut builder = BooleanBufferBuilder::new(len); | ||
| builder.resize(len); | ||
| let slice = builder.as_slice_mut(); |
There was a problem hiding this comment.
nit: calling this target or dest or dst I think would be a more descriptive name for what it is rather than slice
| let mut builder = BooleanBufferBuilder::new(len); | ||
| builder.resize(len); | ||
| let slice = builder.as_slice_mut(); | ||
| match self.keys.nulls().filter(|n| n.null_count() > 0) { |
There was a problem hiding this comment.
This is a fancy way to check for nulls -- TIL Option::filter 👍
| Some(n) => { | ||
| let v = self.keys.values(); | ||
| n.valid_indices() | ||
| .for_each(|idx| set_bit(slice, v[idx].as_usize())) |
There was a problem hiding this comment.
Would there be any value in calling valid_slices here instead? I assume it would be a tradeoff for sparse dictionaries and mostly used dictionaries.
|
As an aside, I really like how the new ScalarBuffer / NullBuffer structures are so easy to work with ❤️ |
|
is this PR waiting on anything else? Or shall we merge it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #4414
Relates to #506
Rationale for this change
Split out from #3558 this adds a
DictionaryArray::occupancywhich provides a mask of the "used" values. This is effectively a selection vector for the values (#4095)What changes are included in this PR?
Are there any user-facing changes?