Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace for loop by try_for_each #3734

Merged
merged 3 commits into from Feb 21, 2023

Conversation

suxiaogang223
Copy link
Contributor

Which issue does this PR close?

Closes #.

Rationale for this change

In the previously submitted merge request, to return Error in the closure of the for_each, change the code from iter to for loop:

    for byte in bytes[0..offset].iter().rev() {
            match byte {
                b'-' => {
                    negative = true;
                }
                b'0'..=b'9' => {
                    let add =
                        T::Native::usize_as((byte - b'0') as usize).mul_checked(base)?;
                    result = result.add_checked(add)?;
                    base = base.mul_checked(T::Native::usize_as(10))?;
                }
                // because of the PARSE_DECIMAL_RE, bytes just contains digit、'-' and '.'.
                _ => {}
            }
        }

I later found out that it was possible to return error using try_for_each, like this:

   bytes[0..offset]
            .iter()
            .rev()
            .try_for_each::<_, Result<(), ArrowError>>(|&byte| match byte {
                b'-' => {
                    negative = true;
                    Ok(())
                }
                b'0'..=b'9' => {
                    let add =
                        T::Native::usize_as((byte - b'0') as usize).mul_checked(base)?;
                    result = result.add_checked(add)?;
                    base = base.mul_checked(T::Native::usize_as(10))?;
                    Ok(())
                }
                // because of the PARSE_DECIMAL_RE, bytes just contains digit、'-' and '.'.
                _ => Ok(()),
            })?;

What changes are included in this PR?

replace for loop by try_for_each

Are there any user-facing changes?

no

@github-actions github-actions bot added the arrow Changes to the arrow crate label Feb 18, 2023
@tustvold tustvold merged commit 25da74c into apache:master Feb 21, 2023
@ursabot
Copy link

ursabot commented Feb 21, 2023

Benchmark runs are scheduled for baseline = 72ad8a7 and contender = 25da74c. 25da74c is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@suxiaogang223 suxiaogang223 deleted the fix/use-try_for_each branch March 3, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants