Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add datetime/interval/duration into dyn scalar comparison #3730

Merged
merged 2 commits into from Feb 21, 2023
Merged

Add datetime/interval/duration into dyn scalar comparison #3730

merged 2 commits into from Feb 21, 2023

Conversation

viirya
Copy link
Member

@viirya viirya commented Feb 16, 2023

Which issue does this PR close?

Closes #3729.

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the arrow Changes to the arrow crate label Feb 16, 2023
@viirya viirya mentioned this pull request Feb 19, 2023
Merged
@viirya viirya requested a review from tustvold February 21, 2023 16:34
tustvold
tustvold approved these changes Feb 21, 2023
View reviewed changes
Copy link
Contributor

@tustvold tustvold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine, some tests might be nice. Hopefully one of the things that will fall out of the ArrayData rework under (#1176) is to reduce the amount of codegen that results from this. As written this make the arrow-ord crate take 20% longer to compile without dyn_cmp_dict...

@viirya viirya changed the title Add datatime/interval/duration into comparison Add datetime/interval/duration into comparison Feb 21, 2023
viirya
viirya commented Feb 21, 2023
View reviewed changes
arrow-ord/src/comparison.rs
);
}

#[test]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some tests to prevent regression in later change.

@viirya viirya changed the title Add datetime/interval/duration into comparison Add datetime/interval/duration into dyn scalar comparison Feb 21, 2023
@viirya viirya merged commit 61ea9f2 into apache:master Feb 21, 2023
@ursabot
Copy link

ursabot commented Feb 21, 2023

Benchmark runs are scheduled for baseline = 18388b2 and contender = 61ea9f2. 61ea9f2 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@tustvold tustvold mentioned this pull request Feb 24, 2023
Closed
@alamb alamb mentioned this pull request Mar 27, 2023
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tustvold tustvold tustvold approved these changes

Assignees
No one assigned
Labels
arrow Changes to the arrow crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add datatime/interval/duration into comparison kernels
3 participants
@viirya @ursabot @tustvold