Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: encoding batch with no columns #3724

Merged
merged 3 commits into from Feb 17, 2023
Merged

Conversation

wangrunji0408
Copy link
Contributor

Which issue does this PR close?

Rationale for this change

When encoding a RecordBatch with no columns, the FlightDataEncoder will return an error:

Arrow(InvalidArgumentError("must either specify a row count or at least one column"))

This PR fixes this problem.

What changes are included in this PR?

Use RecordBatch::try_new_with_options to allow constructing a batch with no columns.

Are there any user-facing changes?

No

Signed-off-by: Runji Wang <wangrunji0408@163.com>
@github-actions github-actions bot added arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate labels Feb 16, 2023
arrow-flight/src/encode.rs Outdated Show resolved Hide resolved
Co-authored-by: Liang-Chi Hsieh <viirya@gmail.com>
@tustvold
Copy link
Contributor

Thank you

arrow-flight/src/encode.rs Outdated Show resolved Hide resolved
Co-authored-by: Liang-Chi Hsieh <viirya@gmail.com>
@viirya viirya merged commit ea48b95 into apache:master Feb 17, 2023
@viirya
Copy link
Member

viirya commented Feb 17, 2023

Thank you!

@ursabot
Copy link

ursabot commented Feb 17, 2023

Benchmark runs are scheduled for baseline = 59016e5 and contender = ea48b95. ea48b95 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@wangrunji0408 wangrunji0408 deleted the fix-no-column branch February 17, 2023 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants