Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: impl Ord/PartialOrd for SortOptions #3723

Merged
merged 1 commit into from Feb 16, 2023

Conversation

crepererum
Copy link
Contributor

Which issue does this PR close?

-

Rationale for this change

Makes it easier to use SortOptions in other code bases (esp. you can auto-derive Ord for other types that use SortOptions).

What changes are included in this PR?

Auto-derive Ord/PartialOrd for SortOptions.

Are there any user-facing changes?

-

@github-actions github-actions bot added the arrow Changes to the arrow crate label Feb 15, 2023
@tustvold
Copy link
Contributor

What is the significance of the output sort order? I guess I'm asking what the intended use-case is?

@crepererum
Copy link
Contributor Author

The use case is that it has SOME deterministic ordering so I can order groups of sorted files downstream in IOx to generate a deterministic output.

@tustvold tustvold merged commit 55c598d into apache:master Feb 16, 2023
@ursabot
Copy link

ursabot commented Feb 16, 2023

Benchmark runs are scheduled for baseline = 22c1381 and contender = 55c598d. 55c598d is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants