Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove azurite test exception #3497

Merged
merged 1 commit into from
Jan 10, 2023

Conversation

tustvold
Copy link
Contributor

@tustvold tustvold commented Jan 9, 2023

Which issue does this PR close?

Closes #.

Rationale for this change

This has apparently been fixed upstream - Azure/Azurite#1696 (comment)

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the object-store Object Store Interface label Jan 9, 2023
@tustvold tustvold changed the title Remove azurite exception Remove azurite test exception Jan 9, 2023
@tustvold tustvold requested a review from viirya January 9, 2023 14:54
let integration = maybe_skip_integration!().build().unwrap();
// Azurite doesn't support listing with spaces - https://github.com/localstack/localstack/issues/6328
put_get_delete_list_opts(&integration, use_emulator).await;
put_get_delete_list_opts(&integration, false).await;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need skip_list_with_spaces in put_get_delete_list_opts?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least historically localstack also had issues with spaces, although this might have been fixed by now... I'll double check when I get a chance

@tustvold tustvold merged commit 005b64c into apache:master Jan 10, 2023
@ursabot
Copy link

ursabot commented Jan 10, 2023

Benchmark runs are scheduled for baseline = e8cc351 and contender = 005b64c. 005b64c is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
object-store Object Store Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants