Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify ArrayData::data_type compatible in PrimitiveArray::from #3440

Merged
merged 1 commit into from Jan 3, 2023
Merged

Verify ArrayData::data_type compatible in PrimitiveArray::from #3440

merged 1 commit into from Jan 3, 2023

Conversation

tustvold
Copy link
Contributor

@tustvold tustvold commented Jan 3, 2023

Which issue does this PR close?

Closes #3439

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@tustvold tustvold requested a review from viirya January 3, 2023 17:37
@github-actions github-actions bot added the arrow Changes to the arrow crate label Jan 3, 2023
tustvold
tustvold commented Jan 3, 2023
View reviewed changes
arrow-array/src/array/primitive_array.rs
expected = "PrimitiveArray expected ArrayData with type Interval(MonthDayNano) got Interval(DayTime)"
)]
fn test_invalid_interval_type() {
let array = IntervalDayTimeArray::from(vec![1, 2, 3]);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change will also prevent coercing TimeUnit, etc... but this is the only one with potential soundness implications

@tustvold tustvold mentioned this pull request Jan 3, 2023
Merged
@tustvold tustvold merged commit 26ea71c into apache:master Jan 3, 2023
@ursabot
Copy link

ursabot commented Jan 3, 2023

Benchmark runs are scheduled for baseline = 08a976f and contender = 26ea71c. 26ea71c is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viirya viirya viirya approved these changes

Assignees
No one assigned
Labels
arrow Changes to the arrow crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PrimitiveArray from ArrayData Unsound For IntervalArray
3 participants
@tustvold @ursabot @viirya