Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a cast test case for decimal negative scale #3203

Merged
merged 2 commits into from Nov 27, 2022

Conversation

viirya
Copy link
Member

@viirya viirya commented Nov 27, 2022

Which issue does this PR close?

Closes #.

Rationale for this change

Clarifying the question at #3139 (comment).

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the arrow Changes to the arrow crate label Nov 27, 2022
Copy link
Contributor

@tustvold tustvold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although I wonder if this should be returning an error?

@viirya
Copy link
Member Author

viirya commented Nov 27, 2022

Although I wonder if this should be returning an error?

Why? I think this is correct behavior.

@tustvold
Copy link
Contributor

For other types we error on truncation, so I figured we would do the same here, if you're fine with truncation why not just use floats? I dunno, I'm not very knowledgeable about decimals, so happy to defer to you 😅

@viirya
Copy link
Member Author

viirya commented Nov 27, 2022

This follows current rounding behavior when casting between decimals with different scales. It rounds to nearest neighbor and round up when both neighbors are equidistant. I added one more test to make it more clear.

@tustvold tustvold merged commit 1daf7d3 into apache:master Nov 27, 2022
@ursabot
Copy link

ursabot commented Nov 27, 2022

Benchmark runs are scheduled for baseline = 8db21ea and contender = 1daf7d3. 1daf7d3 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants