Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RowSelection::iter(), Into<Vec<RowSelector>> and example #3173

Merged
merged 2 commits into from Nov 23, 2022

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Nov 23, 2022

Which issue does this PR close?

Closes #3172

Rationale for this change

see #3172 (Datafusion code wants to count the number of selected items)

What changes are included in this PR?

  1. Add RowSelection::iter()
  2. Add Into<Vec<RowSelector>> (there was only into VecDeque for some reason)
  3. Add a Doc example

Are there any user-facing changes?

new functions and docs

@github-actions github-actions bot added the parquet Changes to the parquet crate label Nov 23, 2022
@alamb alamb changed the title Add RowSelection::iter(), Into<Vec<RowSelector>> and example Add RowSelection::iter(), Into<Vec<RowSelector>> and example Nov 23, 2022
Comment on lines +376 to +377
pub fn iter(&self) -> impl Iterator<Item = &RowSelector> {
self.selectors.iter()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pub fn iter(&self) -> impl Iterator<Item = &RowSelector> {
self.selectors.iter()
pub fn iter(&self) -> impl Iterator<Item = RowSelector> {
self.selectors.iter().copied()

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any reason to copy the RowSelectors around?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not especially, was just an idle suggestion

@tustvold tustvold merged commit cea5146 into apache:master Nov 23, 2022
@ursabot
Copy link

ursabot commented Nov 23, 2022

Benchmark runs are scheduled for baseline = f749e1d and contender = cea5146. cea5146 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parquet Changes to the parquet crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add iterator to RowSelection
4 participants