Add Row size methods (#3160) #3163
Conversation
arrow/src/row/interner.rs
Outdated
| + self.values.buffer_size() | ||
| + self.values.buffer_size() |
| /// Includes the size of `Self`. | ||
| pub fn size(&self) -> usize { | ||
| self.data_type.size() + std::mem::size_of::<Self>() | ||
| - std::mem::size_of::<DataType>() |
There was a problem hiding this comment.
Options is counted by size_of<Self> we need to subtract DataType as otherwise it is counted twice
There was a problem hiding this comment.
self.data_type.size() isn't equal to std::mem::size_of::<DataType>()?
There was a problem hiding this comment.
It is that, plus any additional memory from nested fields
There was a problem hiding this comment.
Oh, - std::mem::size_of::<DataType>() is for data_type: DataType which is already counted in by std::mem::size_of::<Self>()?
|
Benchmark runs are scheduled for baseline = fa51333 and contender = 12a67b9. 12a67b9 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Closes #3160
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?