Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't Skip Serializing Empty Metadata (#3082) #3126

Merged
merged 5 commits into from Nov 21, 2022
Merged

Don't Skip Serializing Empty Metadata (#3082) #3126

merged 5 commits into from Nov 21, 2022

Conversation

askoa
Copy link
Contributor

@askoa askoa commented Nov 17, 2022

Which issue does this PR close?

Closes #3082

@github-actions github-actions bot added the arrow Changes to the arrow crate label Nov 17, 2022
@tustvold tustvold added the api-change Changes to the arrow API label Nov 21, 2022
@tustvold tustvold changed the title Remove serde attribute to fix postcard roundtrip. Don't Skip Serializing Empty Metadata (#3082) Nov 21, 2022
arrow-schema/Cargo.toml Outdated Show resolved Hide resolved
@tustvold tustvold merged commit 528a072 into apache:master Nov 21, 2022
@ursabot
Copy link

ursabot commented Nov 21, 2022

Benchmark runs are scheduled for baseline = 870f0fa and contender = 528a072. 528a072 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-change Changes to the arrow API arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Field is not serializable with binary formats
3 participants