Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve schema mismatch error message #3098

Merged
merged 6 commits into from Nov 13, 2022
Merged

Improve schema mismatch error message #3098

merged 6 commits into from Nov 13, 2022

Conversation

askoa
Copy link
Contributor

@askoa askoa commented Nov 13, 2022

Which issue does this PR close?

Closes #3095

@github-actions github-actions bot added the arrow Changes to the arrow crate label Nov 13, 2022
@askoa askoa marked this pull request as ready for review November 13, 2022 15:24
@askoa
Copy link
Contributor Author

askoa commented Nov 13, 2022

Is there any way to kick off the build without me pushing a commit? I think the failures in clippy should be fixed because of #3096 and the other failure seems to be temporary.

viirya
viirya approved these changes Nov 13, 2022
View reviewed changes
arrow-schema/src/field.rs Outdated Show resolved Hide resolved
arrow-schema/src/field.rs Outdated Show resolved Hide resolved
@viirya
Copy link
Member

viirya commented Nov 13, 2022

There is a unrelated error in CI. Can you add an empty commit to retrigger it?

@viirya viirya merged commit 430eb84 into apache:master Nov 13, 2022
@viirya
Copy link
Member

viirya commented Nov 13, 2022

Thanks @askoa

@ursabot
Copy link

ursabot commented Nov 13, 2022

Benchmark runs are scheduled for baseline = 46da606 and contender = 430eb84. 430eb84 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@andygrove andygrove mentioned this pull request Nov 15, 2022
Merged
@alamb alamb mentioned this pull request Nov 25, 2022
Closed
@askoa askoa deleted the error-desc branch December 1, 2022 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viirya viirya viirya approved these changes

Assignees
No one assigned
Labels
arrow Changes to the arrow crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve "Fail to merge schema" error messages
3 participants
@askoa @viirya @ursabot