Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

early type checks in RowConverter #3080

Merged
merged 4 commits into from Nov 10, 2022
Merged

early type checks in RowConverter #3080

merged 4 commits into from Nov 10, 2022

Commits on Nov 10, 2022

  1. refactor: remove duplicate code 

    Decimal types are already handled by `downcast_primitive`.
    @crepererum
    crepererum committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    3a3a119 View commit details
    Browse the repository at this point in the history

  2. refactor: check supported types when creating RowConverter 

    Check supported row format types when creating the converter instead of
during conversion. Also add an additional method
`RowConverter::supports_fields` to check types w/o relying on an error.

Closes apache#3077.
    @crepererum
    crepererum committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    cff7a4a View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/master' into crepererum/issue3077

    @tustvold
    tustvold committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    8eda7f7 View commit details
    Browse the repository at this point in the history

  4. Simplify

    @tustvold
    tustvold committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    0eda1e3 View commit details
    Browse the repository at this point in the history