fix: pin ahash to 0.8.0 #3048
fix: pin ahash to 0.8.0 #3048
Conversation
0.8.1 has a bug tkaitchuck/aHash#143
|
I believe this pin be just added by impacted downstreams, i.e. those that are using custom build tooling. I'm not sure we need to pin this here? |
Can you pin a sub-dependency? |
|
Yes |
I had tried but it didn’t seem to be working. Will try again. Even so, ahash-8.0.1 uses cfg-target-abi, which is unstable. Doesn’t this then mean that installing arrow will fail for anyone not running a nightly, as it is for me? |
|
My understanding is it is just ignored outside of nightly |
You mentioned this would affect folks using custom build tooling. I’m using Bazel, are tou saying that might be related? |
|
Yes, we had issues with hakari parsing the ahash crate, that @carols10cents tracked down to EmbarkStudios/cfg-expr#52 (comment) My understanding is that some parsers don't correctly understand unstable cargo build attributes, and this causes custom build tooling to fail. |
| @@ -38,10 +38,10 @@ path = "src/lib.rs" | |||
| bench = false | |||
|
|
|||
| [target.'cfg(target_arch = "wasm32")'.dependencies] | |||
| ahash = { version = "0.8", default-features = false, features = ["compile-time-rng"] } | |||
| ahash = { version = "0.8.0", default-features = false, features = ["compile-time-rng"] } | |||
There was a problem hiding this comment.
| ahash = { version = "0.8.0", default-features = false, features = ["compile-time-rng"] } | |
| ahash = { version = "=0.8.0", default-features = false, features = ["compile-time-rng"] } |
FYI you will need an exact version pin, cargo applies semver compatibility by default
|
Closing this, as workarounds exist, and the change to ahash has been reverted - tkaitchuck/aHash#145 |
0.8.1 has a bug tkaitchuck/aHash#143