Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept any &dyn Array in nullif kernel #2940

Merged
merged 3 commits into from Oct 31, 2022
Merged

Accept any &dyn Array in nullif kernel #2940

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
abdb514
Accept any &dyn Array in nullif kernel
tustvold Oct 26, 2022
78b2608
Clippy
tustvold Oct 26, 2022
934c470
Update docs
tustvold Oct 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 4 additions & 4 deletions arrow-buffer/src/buffer/ops.rs
View file
Open in desktop
Expand Up @@ -66,10 +66,10 @@ pub fn bitwise_bin_op_helper<F>(
right: &Buffer,
right_offset_in_bits: usize,
len_in_bits: usize,
op: F,
mut op: F,
) -> Buffer
where
F: Fn(u64, u64) -> u64,
F: FnMut(u64, u64) -> u64,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just a drive by fix to make this accept mutable closures - this is a backwards compatible change

{
let left_chunks = left.bit_chunks(left_offset_in_bits, len_in_bits);
let right_chunks = right.bit_chunks(right_offset_in_bits, len_in_bits);
Expand Down Expand Up @@ -97,10 +97,10 @@ pub fn bitwise_unary_op_helper<F>(
left: &Buffer,
offset_in_bits: usize,
len_in_bits: usize,
op: F,
mut op: F,
) -> Buffer
where
F: Fn(u64) -> u64,
F: FnMut(u64) -> u64,
{
// reserve capacity and set length so we can get a typed view of u64 chunks
let mut result =
Expand Down