fix testcases while chrono-tz enabled #2932
Conversation
| assert_eq!("1997-05-19 00:00:00.005 +00:00", c.value(0)); | ||
| assert_eq!("2018-12-25 00:00:00.001 +00:00", c.value(1)); |
There was a problem hiding this comment.
the result for Timestamp(Unit, Some("UTC")) should contains +00:00
There was a problem hiding this comment.
Is the space before the timezone offset expected here?
There was a problem hiding this comment.
It appears to output https://docs.rs/chrono/latest/chrono/struct.DateTime.html#method.to_rfc2822 which has spaces
Edit: it actually outputs some chrono default format, we should potentially file a ticket to switch to using an actual standard 🤔
There was a problem hiding this comment.
i'm working on #2917 and found this issue as well. Is 2018-01-26T18:30:09.453829+08:00 preferred?
There was a problem hiding this comment.
That looks like rfc3339 format, which is probably the most common or standardized format.
chrono has a separate function for this format which also allows specifying how many fractional digits you want.
| Some("1970-01-01 20:30:00 +10:00"), | ||
| None, | ||
| Some("1970-01-02 09:58:59"), | ||
| Some("1970-01-02 09:58:59 +10:00"), |
There was a problem hiding this comment.
the result for Timestamp(Unit, Some("Australia/Sydnet")) should contains +10:00
arrow/src/csv/writer.rs
Outdated
| consectetur adipiscing elit,,2,false,2019-04-18T10:54:47.378000000,06:51:20,cupcakes | ||
| sed do eiusmod tempor,-556132.25,1,,2019-04-18T02:45:55.555000000,23:46:03,foo | ||
| Lorem ipsum dolor sit amet,123.564532,3,true,,00:20:34,cupcakes | ||
| consectetur adipiscing elit,,2,false,2019-04-18T10:54:47.378000000+00:00,06:51:20,cupcakes | ||
| sed do eiusmod tempor,-556132.25,1,,2019-04-18T02:45:55.555000000+00:00,23:46:03,foo | ||
| consectetur adipiscing elit,,2,false,2019-04-18T10:54:47.378000000,06:51:20,cupcakes | ||
| sed do eiusmod tempor,-556132.25,1,,2019-04-18T02:45:55.555000000,23:46:03,foo |
There was a problem hiding this comment.
Timestamp<Unit, None> contains no timezone
| 2019-04-18T20:54:47.378000000+10:00,2019-04-18T10:54:47.378000000 | ||
| 2021-10-30T17:59:07.000000000+11:00,2021-10-30T06:59:07.000000000\n"; |
There was a problem hiding this comment.
Timestamp<Unit, None> contains no timezone
|
Could we possibly add checks for this to CI? |
tustvold
added
the
development-process
.github/workflows/arrow.yml
Outdated
| - name: Test arrow with all features | ||
| run: cargo test -p arrow --all-features |
There was a problem hiding this comment.
@tustvold i just added cargo test with all features
There was a problem hiding this comment.
I think this will fail on stable, as it will enable the SIMD feature
Edit: I'm currently digging around in the CI anyway, so I'll push a commit to fix
Edit Edit: I see you got there first 👍
| - name: Test --features=force_validate,prettyprint,ipc_compression,ffi,dyn_cmp_dict,dyn_arith_dict,chrono-tz | ||
| run: | | ||
| cargo test -p arrow --features=force_validate,prettyprint,ipc_compression,ffi,dyn_cmp_dict,dyn_arith_dict | ||
| cargo test -p arrow --features=force_validate,prettyprint,ipc_compression,ffi,dyn_cmp_dict,dyn_arith_dict,chrono-tz |
There was a problem hiding this comment.
@tustvold You're right, it failed while all features enabled. I added chrono-tz here instead
|
Clippy seems to be finding more code to complain about now 😢 |
I just remove chrono-tz from clippy. I can submitt another pr to fix that and add it in clippy later |
|
Benchmark runs are scheduled for baseline = f812d2c and contender = ed5843e. ed5843e is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Closes #2931
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?