Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter DecimalArray as PrimitiveArray ~5x Faster (#2637) #2870

Merged
merged 3 commits into from Oct 15, 2022

Conversation

tustvold
Copy link
Contributor

Which issue does this PR close?

Part of #2637

Rationale for this change

Uses the optimised filter primitive implementation for filtering decimal arrays

What changes are included in this PR?

Are there any user-facing changes?

No

@github-actions github-actions bot added the arrow Changes to the arrow crate label Oct 14, 2022
Copy link
Contributor

@Dandandan Dandandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - would be interested what is the performance change

@tustvold
Copy link
Contributor Author

filter decimal128 (kept 1/2)
                        time:   [92.406 µs 92.455 µs 92.515 µs]
                        change: [-66.107% -66.043% -65.967%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 11 outliers among 100 measurements (11.00%)
  4 (4.00%) high mild
  7 (7.00%) high severe

filter decimal128 high selectivity (kept 1023/1024)
                        time:   [51.903 µs 52.226 µs 52.571 µs]
                        change: [-58.848% -58.570% -58.303%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 3 outliers among 100 measurements (3.00%)
  3 (3.00%) high mild

filter decimal128 low selectivity (kept 1/1024)
                        time:   [2.8865 µs 2.8877 µs 2.8891 µs]
                        change: [-20.743% -20.519% -20.286%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 1 outliers among 100 measurements (1.00%)
  1 (1.00%) high severe

filter context decimal128 (kept 1/2)
                        time:   [41.956 µs 43.880 µs 45.982 µs]
                        change: [-84.841% -84.535% -84.193%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 13 outliers among 100 measurements (13.00%)
  13 (13.00%) high severe

filter context decimal128 high selectivity (kept 1023/1024)
                        time:   [49.703 µs 50.000 µs 50.358 µs]
                        change: [-58.433% -58.128% -57.825%] (p = 0.00 < 0.05)
                        Performance has improved.

filter context decimal128 low selectivity (kept 1/1024)
                        time:   [367.45 ns 367.51 ns 367.59 ns]
                        change: [-88.839% -88.822% -88.791%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 7 outliers among 100 measurements (7.00%)
  1 (1.00%) low mild
  6 (6.00%) high severe

@tustvold tustvold changed the title Filter DecimalArray as PrimitiveArray (#2637) Filter DecimalArray as PrimitiveArray ~80% Faster (#2637) Oct 15, 2022
@tustvold tustvold merged commit ede36d7 into apache:master Oct 15, 2022
@ursabot
Copy link

ursabot commented Oct 15, 2022

Benchmark runs are scheduled for baseline = f055f51 and contender = ede36d7. ede36d7 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@Dandandan
Copy link
Contributor

Nice @tustvold

@tustvold tustvold changed the title Filter DecimalArray as PrimitiveArray ~80% Faster (#2637) Filter DecimalArray as PrimitiveArray ~5x Faster (#2637) Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants