Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Take decimal as primitive (#2637) #2869

Merged
merged 1 commit into from Oct 14, 2022
Merged

Take decimal as primitive (#2637) #2869

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
52 changes: 13 additions & 39 deletions arrow/src/compute/kernels/take.rs
View file
Open in desktop
Expand Up @@ -134,10 +134,19 @@ where
let values = values.as_any().downcast_ref::<BooleanArray>().unwrap();
Ok(Arc::new(take_boolean(values, indices)?))
}
DataType::Decimal128(_, _) => {
let decimal_values =
values.as_any().downcast_ref::<Decimal128Array>().unwrap();
Ok(Arc::new(take_decimal128(decimal_values, indices)?))
DataType::Decimal128(p, s) => {
let decimal_values = values.as_any().downcast_ref::<Decimal128Array>().unwrap();
let array = take_primitive(decimal_values, indices)?
.with_precision_and_scale(*p, *s)
.unwrap();
Ok(Arc::new(array))
}
DataType::Decimal256(p, s) => {
let decimal_values = values.as_any().downcast_ref::<Decimal256Array>().unwrap();
let array = take_primitive(decimal_values, indices)?
.with_precision_and_scale(*p, *s)
.unwrap();
Ok(Arc::new(array))
}
DataType::Utf8 => {
let values = values
Expand Down Expand Up @@ -429,41 +438,6 @@ where
Ok((buffer, nulls))
}

/// `take` implementation for decimal arrays
fn take_decimal128<IndexType>(
decimal_values: &Decimal128Array,
indices: &PrimitiveArray<IndexType>,
) -> Result<Decimal128Array>
where
IndexType: ArrowNumericType,
IndexType::Native: ToPrimitive,
{
indices
.iter()
.map(|index| {
// Use type annotations below for readability (was blowing
// my mind otherwise)
let t: Option<Result<Option<_>>> = index.map(|index| {
let index = ToPrimitive::to_usize(&index).ok_or_else(|| {
ArrowError::ComputeError("Cast to usize failed".to_string())
})?;

if decimal_values.is_null(index) {
Ok(None)
} else {
Ok(Some(decimal_values.value(index)))
}
});
let t: Result<Option<Option<_>>> = t.transpose();
let t: Result<Option<_>> = t.map(|t| t.flatten());
t
})
.collect::<Result<Decimal128Array>>()?
// PERF: we could avoid re-validating that the data in
// Decimal128Array was in range as we know it came from a valid Decimal128Array
.with_precision_and_scale(decimal_values.precision()?, decimal_values.scale()?)
}

/// `take` implementation for all primitive arrays
///
/// This checks if an `indices` slot is populated, and gets the value from `values`
Expand Down