-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] Add pub api for checking column index is sorted. #2849
Conversation
@tustvold @liukun4515 @alamb seems long time no contribution 😂 |
parquet/src/file/page_index/index.rs
Outdated
impl Index { | ||
/// Return min/max elements inside ColumnIndex are ordered or not. | ||
pub fn is_sorted(&self) -> bool { | ||
match self { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps something for a follow up, but I wonder if we could add an accessor for boundary_order on Index, as it appears to be the same type for all variants.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reasonable!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tustvold still need approve Ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could now be simplified to
// 0:UNORDERED, 1:ASCENDING ,2:DESCENDING,
self.get_boundary_order().0 > (BoundaryOrder::UNORDERED.0)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tustvold yes
/// Get boundary_order of this page index. | ||
pub fn get_boundary_order(&self) -> Option<BoundaryOrder> { | ||
match self { | ||
Index::NONE => None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The explicit coding of NONE is kind of unfortunate, but that ship has probably sailed now
Benchmark runs are scheduled for baseline = 2ae2309 and contender = c3aac93. c3aac93 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Closes #2848.
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?