Add string_dictionary benches for row format (#2677) #2816
Conversation
tustvold
force-pushed
the
add-string-dictionary-benches-row
branch
from
8046e07
to
63360fa
Compare
| @@ -85,6 +88,46 @@ fn row_bench(c: &mut Criterion) { | |||
| }); | |||
| }); | |||
|
|
|||
| let cols = | |||
There was a problem hiding this comment.
I am sorry for being dense, but I don't see any difference in the first three benchmarks. They all use
create_string_dict_array::<Int32Type>(4096, 0., 100)
|
Failure is unrelated, working on fixing it currently |
|
Benchmark runs are scheduled for baseline = 9c1748f and contender = 76da624. 76da624 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Part of #2677
Rationale for this change
What changes are included in this PR?
Adds benchmarks of the dictionary interning logic for the row format
Are there any user-facing changes?
No, this just adds some more benchmarks