Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify FixedLengthEncoding #2812

Merged
merged 1 commit into from Oct 3, 2022

Conversation

tustvold
Copy link
Contributor

Which issue does this PR close?

Part of #2677

Rationale for this change

Const generics have a lot of rough edges, including rust-lang/rust#80528

They were always a bit overkill for the needs here, it was only a lack of imagination on my part that made me reach for them 馃槄

What changes are included in this PR?

Are there any user-facing changes?

No, this trait is an implementation detail of the row format

@github-actions github-actions bot added the arrow Changes to the arrow crate label Sep 30, 2022
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me -- do we need to run any benchmarks?

@tustvold
Copy link
Contributor Author

tustvold commented Oct 3, 2022

Benchmarks show no major change in performance, this doesn't change any of the types involved, just the trait plumbing, and so it would be surprising if this changed performance (although stranger things have happened)

@tustvold tustvold merged commit 931c6fc into apache:master Oct 3, 2022
@ursabot
Copy link

ursabot commented Oct 3, 2022

Benchmark runs are scheduled for baseline = 70054fd and contender = 931c6fc. 931c6fc is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped 鈿狅笍 Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped 鈿狅笍 Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped 鈿狅笍 Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped 鈿狅笍 Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants