Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BinaryBuilder and StringBuilder Capacity Allocation in StructBuilder #2784

Merged
merged 1 commit into from Sep 27, 2022

Conversation

chunshao90
Copy link
Contributor

@chunshao90 chunshao90 commented Sep 27, 2022

…parameters in struct_builder

Which issue does this PR close?

Closes #2783 .

Rationale for this change

What changes are included in this PR?

Fix BinaryBuilder and StringBuilder initialization parameters in struct_builder.

Are there any user-facing changes?

No.

@chunshao90 chunshao90 changed the title fix(arrow-array): fix BinaryBuilder and StringBuilder initialization … fix(arrow-array): fix BinaryBuilder and StringBuilder initialization in struct_builder Sep 27, 2022
Copy link
Contributor

@tustvold tustvold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this, looks good to me 👍

@tustvold tustvold merged commit 333633e into apache:master Sep 27, 2022
@tustvold tustvold changed the title fix(arrow-array): fix BinaryBuilder and StringBuilder initialization in struct_builder Fix BinaryBuilder and StringBuilder Capacity Allocation in StructBuilder Sep 27, 2022
@ursabot
Copy link

ursabot commented Sep 27, 2022

Benchmark runs are scheduled for baseline = 70bcfbc and contender = 333633e. 333633e is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@tustvold tustvold added the arrow Changes to the arrow crate label Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BinaryBuilder and StringBuilder initialization parameters in struct_builder may be wrong
3 participants