You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Builds on the work of #2595 and removes FromStr from ArrowNativeType. This avoids conflating serialization logic, with the logic for representing data in primitive arrays.
What changes are included in this PR?
Removes std::str::FromStr from ArrowNativeType
Are there any user-facing changes?
Yes, they will need to add an additional trait bound if they are relying on this behaviour
Benchmark runs are scheduled for baseline = 7c8080c and contender = d52cae0. d52cae0 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
alamb
changed the title
Remove ArrowNativeType: FromStr
Remove ArrowNativeType::FromStrSep 30, 2022
api-changeChanges to the arrow APIarrowChanges to the arrow crate
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
alamb
changed the title
Which issue does this PR close?
Part of #2637
Part of #2300
Rationale for this change
Builds on the work of #2595 and removes
FromStrfromArrowNativeType. This avoids conflating serialization logic, with the logic for representing data in primitive arrays.What changes are included in this PR?
Removes
std::str::FromStrfromArrowNativeTypeAre there any user-facing changes?
Yes, they will need to add an additional trait bound if they are relying on this behaviour