Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dyn_arith_dict feature flag #2760

Merged
merged 2 commits into from Sep 20, 2022
Merged

Conversation

tustvold
Copy link
Contributor

Which issue does this PR close?

Follow on to #2597

Rationale for this change

$ time cargo build --release --no-default-features
________________________________________________________
Executed in   22.13 secs    fish           external
   usr time  120.80 secs  561.00 micros  120.80 secs
   sys time    3.70 secs  107.00 micros    3.69 secs
$ time cargo build --release --no-default-features --features dyn_arith_dict
________________________________________________________
Executed in   38.73 secs    fish           external
   usr time  167.26 secs  613.00 micros  167.26 secs
   sys time    4.26 secs  106.00 micros    4.26 secs

What changes are included in this PR?

Gates arithmetic operations between primitive dictionary arrays behind a feature flag. Primitive dictionaries are fairly niche, array operations on primitive dictionaries are even more niche. I think the benefits to compilation time justify the overheads of an additional feature flag

Are there any user-facing changes?

Arithmetic operations on dictionaries now require enabling via a feature flag

@tustvold tustvold added the api-change Changes to the arrow API label Sep 20, 2022
@github-actions github-actions bot added the arrow Changes to the arrow crate label Sep 20, 2022
Comment on lines +556 to 557
#[cfg(feature = "dyn_arith_dict")]
fn math_op_dict<K, T, F>(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, as add_dyn has no the feature attribute, I thought that it cannot be built. But it appears not.

@tustvold tustvold merged commit 74f639c into apache:master Sep 20, 2022
@ursabot
Copy link

ursabot commented Sep 20, 2022

Benchmark runs are scheduled for baseline = 5b601b3 and contender = 74f639c. 74f639c is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@alamb alamb changed the title Add dyn_arith_dict feature flag Add dyn_arith_dict feature flag Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-change Changes to the arrow API arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants