Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix verify_release_candidate.sh for new arrow subcrates #2752

Merged
merged 1 commit into from Sep 16, 2022

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Sep 16, 2022

Which issue does this PR close?

Fixes: #2751
re #2665

Rationale for this change

#2693 added a new arrow-buffer crate on which arrow depends which is good 馃帀

鈿栵笍 but it means we can no longer run cargo publish --dry-run for arrow as it it now depends on an as-yet-unpublushed crate (arrow-buffer)

What changes are included in this PR?

  1. change to run cargo publish --dry-run for the leaf crate arrow-buffer rather than arrow
  2. Remove unecessary (and ineffective sed command)

Are there any user-facing changes?

@alamb alamb marked this pull request as ready for review September 16, 2022 21:00
@@ -116,21 +116,16 @@ test_source_distribution() {
export ARROW_TEST_DATA=$PWD/arrow-testing-data/data
export PARQUET_TEST_DATA=$PWD/parquet-testing-data/data

# use local modules because we don't publish modules to crates.io yet
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These regex don't actually match anything and I found the script passes for me without this code

Comment on lines +128 to 130
pushd arrow-buffer
cargo publish --dry-run
popd
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems due to rust-lang/cargo#1565

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only verifying on leaf crates seems not perfect, but it appears that no better way to fix it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, it would be great to verify all the crates...

@iajoiner
Copy link
Contributor

@alamb Really thanks! This works!

@alamb alamb merged commit ca00b67 into apache:master Sep 16, 2022
@ursabot
Copy link

ursabot commented Sep 16, 2022

Benchmark runs are scheduled for baseline = 5a55406 and contender = ca00b67. ca00b67 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped 鈿狅笍 Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped 鈿狅笍 Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped 鈿狅笍 Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped 鈿狅笍 Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@tustvold tustvold added the development-process Related to development process of arrow-rs label Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development-process Related to development process of arrow-rs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

verify_release_candidate.sh script fails verifying 23.0.0 rc 2
5 participants