New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speed up checked kernels for non-null data (~1.4-5x faster) #2749
Conversation
Ah wait - this changes the semantics slightly as the overflow check probably isn't meant to work on null-values... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, no point zero allocating if you don't need to 👍
Benchmark runs are scheduled for baseline = ca00b67 and contender = 46fcb0c. 46fcb0c is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Closes #2747
Rationale for this change
We can use some more optimized ways to generate new arrays from fallible iterators:
(There is an overflow in the benchmark).
What changes are included in this PR?
Are there any user-facing changes?