Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version to 23.0.0 and update CHANGELOG, add label_issue.py script #2734

Merged
merged 18 commits into from Sep 16, 2022

Conversation

iajoiner
Copy link
Contributor

@iajoiner iajoiner commented Sep 15, 2022

Which issue does this PR close?

Re #2665.
Closes #2727

Rationale for this change

Prepare for biweekly release

What changes are included in this PR?

  1. New version
  2. Updated changelog -- see https://github.com/iajoiner/arrow-rs/blob/prepare_for_23.0.0/CHANGELOG.md

Are there any user-facing changes?

Yes

@iajoiner
Copy link
Contributor Author

@andygrove @alamb Looks like we can start to automatically generate pull requests and issues using the GitHub APIs.

@alamb
Copy link
Contributor

alamb commented Sep 15, 2022

Thanks @iajoiner -- I am working on a script for #2727 now

@iajoiner
Copy link
Contributor Author

@alamb Thanks! I will file the PR for the release PR generation script now and then another one for the issue generation script by Monday. The amount of repetitive human work for releases should be further minimized.

@github-actions github-actions bot added arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate parquet Changes to the parquet crate parquet-derive labels Sep 15, 2022
@alamb alamb changed the title Update version to 23.0.0 and update CHANGELOG Update version to 23.0.0 and update CHANGELOG, add label_issue.py script Sep 16, 2022
@@ -0,0 +1,151 @@
##############################################################################
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI @iajoiner -- here is my hacky python script to update github labels

It does appear to work... But is definitely a bit of a hack

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iajoiner when I ran the update_changelog.sh script locally it modified the CHANGELOG-old.md file (even though that file already had the old changelog and probably shouldn't be updated again)

@iajoiner
Copy link
Contributor Author

@alamb I think we can modify the script and either an argument or detect whether CHANGELOG-old.md is already up-to-date. I prefer the latter and will make the changes next week.

CHANGELOG.md Outdated
- Refactor FixedSizeBinaryBuilder Constructors [\#2516](https://github.com/apache/arrow-rs/pull/2516) [[parquet](https://github.com/apache/arrow-rs/labels/parquet)] [[arrow](https://github.com/apache/arrow-rs/labels/arrow)] ([psvri](https://github.com/psvri))
- Refactor BooleanBuilder Constructors [\#2515](https://github.com/apache/arrow-rs/pull/2515) [[arrow](https://github.com/apache/arrow-rs/labels/arrow)] ([psvri](https://github.com/psvri))
- Refactor UnionBuilder Constructors [\#2488](https://github.com/apache/arrow-rs/pull/2488) [[arrow](https://github.com/apache/arrow-rs/labels/arrow)] ([psvri](https://github.com/psvri))
- DictionaryBuilders can Create Invalid DictionaryArrays [\#2684](https://github.com/apache/arrow-rs/issues/2684) [[parquet](https://github.com/apache/arrow-rs/labels/parquet)] [[arrow](https://github.com/apache/arrow-rs/labels/arrow)]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems a bit odd that we have both issues and PRs in here, perhaps we could exclude api-change from the auto-label, otherwise it obfuscates what the actual breaking change was?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree -- I think this issue was marked with api-change by an earlier version of the script -- I have subsequently blacklisted (won't transfer) api-change labels to issues and will fix this one manually

@alamb alamb merged commit 1da2bfb into apache:master Sep 16, 2022
@alamb
Copy link
Contributor

alamb commented Sep 16, 2022

I forgot to update a version in the toml files: #2748

@ursabot
Copy link

ursabot commented Sep 16, 2022

Benchmark runs are scheduled for baseline = 968a767 and contender = 1da2bfb. 1da2bfb is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@iajoiner iajoiner deleted the prepare_for_23.0.0 branch April 7, 2023 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate parquet Changes to the parquet crate parquet-derive
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automate labeling of CHANGELOG.md entries
5 participants