Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix object_store multipart uploads on S3 Compatible Stores #2731

Merged
merged 1 commit into from Sep 15, 2022
Merged

Fix object_store multipart uploads on S3 Compatible Stores #2731

merged 1 commit into from Sep 15, 2022

Commits on Sep 15, 2022

  1. Fix multipart uploads on Minio 

    The official Minio SDK uses "uploads=" as the URL when it initiates a
multipart upload instead of "uploads". This affects the AWSV4 signature
and causes object_store to fail a signature check when initiating the
upload to Minio.

It's possible that this contradicts the AWS S3 API docs:
https://docs.aws.amazon.com/AmazonS3/latest/API/API_CreateMultipartUpload.html#API_CreateMultipartUpload_RequestSyntax
and we need to instead keep the URL as `?uploads` and
change the URL that goes into the signature instead.
    @mildbyte
    mildbyte committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    c51cda2 View commit details
    Browse the repository at this point in the history