Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DataType::is_nested() #2707

Merged
merged 2 commits into from Sep 12, 2022
Merged

Add DataType::is_nested() #2707

merged 2 commits into from Sep 12, 2022

Conversation

kfastov
Copy link
Contributor

@kfastov kfastov commented Sep 12, 2022

Which issue does this PR close?

Closes #2704.

Rationale for this change

Already described in the issue

What changes are included in this PR?

is_nested function is added to DataType, that returns true if the provided type is nested (List, FixedSizeList, LargeList, Struct, Union or Map)

Are there any user-facing changes?

User will be able to use DataType::is_nested function

@github-actions github-actions bot added the arrow Changes to the arrow crate label Sep 12, 2022
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if some unit test would be helpful ? So that we don't forget it is in the API

Though the test would basically just be a re-implementation so I agree adding it is debatable.

Thanks for this @kfastov -- really nice

Co-authored-by: Liang-Chi Hsieh <viirya@gmail.com>
@kfastov
Copy link
Contributor Author

kfastov commented Sep 12, 2022

@alamb
Yes, in this case, I can't think of a test that will break if API changes.
Thanks for approving, I've added the List type to the documentation comment

@alamb alamb merged commit 0ba5c5b into apache:master Sep 12, 2022
@alamb
Copy link
Contributor

alamb commented Sep 12, 2022

Thanks again @kfastov for the fast turnaround 🐎

@ursabot
Copy link

ursabot commented Sep 12, 2022

Benchmark runs are scheduled for baseline = be33fb3 and contender = 0ba5c5b. 0ba5c5b is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add DataType function to detect nested types
5 participants