Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate RecordBatch::concat replace with concat_batches (#2594) #2683

Merged
merged 1 commit into from Sep 8, 2022

Conversation

tustvold
Copy link
Contributor

@tustvold tustvold commented Sep 8, 2022

Which issue does this PR close?

Part of #2594

Rationale for this change

In order to split the core data layout structures, such as RecordBatch, away from IO and compute, the two can't depend on each other.

What changes are included in this PR?

Are there any user-facing changes?

Yes

@tustvold tustvold added the api-change Changes to the arrow API label Sep 8, 2022
@tustvold tustvold changed the title Deprecate RecordBatch::concat (#2594) Deprecate RecordBatch::concat replace with concat_batches (#2594) Sep 8, 2022
@tustvold tustvold merged commit 7a22ec0 into apache:master Sep 8, 2022
@ursabot
Copy link

ursabot commented Sep 8, 2022

Benchmark runs are scheduled for baseline = 326ea5e and contender = 7a22ec0. 7a22ec0 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@tustvold
Copy link
Contributor Author

tustvold commented Sep 8, 2022

Ffs... Gitflub Inactions didn't actually run on this PR...

@tustvold tustvold mentioned this pull request Sep 8, 2022
@alamb alamb added the arrow Changes to the arrow crate label Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-change Changes to the arrow API arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants