Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip RowSelectors with zero rows #2678

Merged
merged 2 commits into from Sep 8, 2022
Merged

Skip RowSelectors with zero rows #2678

merged 2 commits into from Sep 8, 2022

Conversation

askoa
Copy link
Contributor

@askoa askoa commented Sep 7, 2022

Which issue does this PR close?

Closes #2669

Are there any user-facing changes?

no user-facing or breaking changes.

@github-actions github-actions bot added the parquet Changes to the parquet crate label Sep 7, 2022
Copy link
Contributor

@tustvold tustvold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we possibly get a test of this

@askoa
Copy link
Contributor Author

askoa commented Sep 7, 2022

Could we possibly get a test of this

Is it okay if I modify the test test_fuzz_async_reader_selection to include zero RowSelectors

@tustvold
Copy link
Contributor

tustvold commented Sep 7, 2022

I think it would be nice to have a fully reproducible test, the fuzz tests are really there to find gaps in test coverage not to serve as it.

@askoa
Copy link
Contributor Author

askoa commented Sep 7, 2022

I think it would be nice to have a fully reproducible test, the fuzz tests are really there to find gaps in test coverage not to serve as it.

I created a test borrowing heavily from the fuzz test. Let me know if it works.

Copy link
Contributor

@tustvold tustvold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@tustvold tustvold merged commit 0b59f05 into apache:master Sep 8, 2022
@ursabot
Copy link

ursabot commented Sep 8, 2022

Benchmark runs are scheduled for baseline = df4906d and contender = 0b59f05. 0b59f05 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parquet Changes to the parquet crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid results with RowSelector having row_count of 0
3 participants