Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use BitIndexIterator in min_max_helper #2675

Merged
merged 1 commit into from Sep 7, 2022

Conversation

viirya
Copy link
Member

@viirya viirya commented Sep 7, 2022

Which issue does this PR close?

Closes #2674.

Rationale for this change

min nulls 512           time:   [1.0670 µs 1.0697 µs 1.0736 µs]                           
                        change: [-43.808% -43.357% -42.886%] (p = 0.00 < 0.05)
                        Performance has improved.

max nulls 512           time:   [1.1034 µs 1.1092 µs 1.1142 µs]                           
                        change: [-44.535% -44.077% -43.658%] (p = 0.00 < 0.05)
                        Performance has improved.

min string 512          time:   [1.5545 µs 1.5591 µs 1.5655 µs]                            
                        change: [-2.2943% -1.8124% -1.3211%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 13 outliers among 100 measurements (13.00%)
  5 (5.00%) high mild
  8 (8.00%) high severe

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the arrow Changes to the arrow crate label Sep 7, 2022
@Dandandan Dandandan merged commit b36bc88 into apache:master Sep 7, 2022
@ursabot
Copy link

ursabot commented Sep 7, 2022

Benchmark runs are scheduled for baseline = c8bf1ca and contender = b36bc88. b36bc88 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use BitIndexIterator in min_max_helper
4 participants