Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ffi, json compilation check #2671

Merged
merged 2 commits into from Sep 6, 2022
Merged

Add ffi, json compilation check #2671

merged 2 commits into from Sep 6, 2022

Conversation

viirya
Copy link
Member

@viirya viirya commented Sep 6, 2022

Which issue does this PR close?

Closes #.

Rationale for this change

To prevent similar error like #2659, #2667 in the future, this patch adds compilation check for ffi, json features.

What changes are included in this PR?

Are there any user-facing changes?

@viirya viirya changed the title Add ffi compilation check Add ffi, json compilation check Sep 6, 2022
@viirya viirya merged commit d73d78f into apache:master Sep 6, 2022
@viirya viirya deleted the ci_tweak branch September 6, 2022 22:17
@ursabot
Copy link

ursabot commented Sep 6, 2022

Benchmark runs are scheduled for baseline = 4e65952 and contender = d73d78f. d73d78f is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@tustvold tustvold added the development-process Related to development process of arrow-rs label Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development-process Related to development process of arrow-rs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants