Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ffi feature also requires layout #2660

Merged
merged 1 commit into from Sep 6, 2022
Merged

ffi feature also requires layout #2660

merged 1 commit into from Sep 6, 2022

Conversation

viirya
Copy link
Member

@viirya viirya commented Sep 6, 2022

Which issue does this PR close?

Closes #2659.

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the arrow Changes to the arrow crate label Sep 6, 2022
@viirya
Copy link
Member Author

viirya commented Sep 6, 2022

cc @tustvold @alamb

Copy link
Contributor

@tustvold tustvold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could possibly tweak ci to catch this in future

@viirya
Copy link
Member Author

viirya commented Sep 6, 2022

Could possibly tweak ci to catch this in future

Run a pipeline with ffi only?

@tustvold
Copy link
Contributor

tustvold commented Sep 6, 2022

Yeah we already have some cargo check jobs for this purpose, could possibly add a few more variants. Depends when we eventually split the crate, feature flags are a bit of a hack 😅

@viirya
Copy link
Member Author

viirya commented Sep 6, 2022

I see. 😄

Yea, I will add a few more variants including ffi in another PR.

@viirya viirya merged commit 5976784 into apache:master Sep 6, 2022
@viirya
Copy link
Member Author

viirya commented Sep 6, 2022

Thanks.

@viirya viirya deleted the ffi_layout branch September 6, 2022 07:56
@ursabot
Copy link

ursabot commented Sep 6, 2022

Benchmark runs are scheduled for baseline = 8ea6ca1 and contender = 5976784. 5976784 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

clippy error: unresolved import crate::array::layout
3 participants