Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add overflow-checking variant for primitive arithmetic kernels and explicitly define overflow behavior #2643

Merged
merged 11 commits into from Sep 4, 2022
Merged

Add overflow-checking variant for primitive arithmetic kernels and explicitly define overflow behavior #2643

merged 11 commits into from Sep 4, 2022

Commits on Sep 3, 2022

  1. Add overflow-checking variant for add kernel and explicitly define ov… 

    …erflow behavior for add
    @viirya
    viirya committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    154f8a5 View commit details
    Browse the repository at this point in the history

  2. For subtract, multiply, divide

    @viirya
    viirya committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    02a2a80 View commit details
    Browse the repository at this point in the history

  3. Fix tests

    @viirya
    viirya committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    74d8cc9 View commit details
    Browse the repository at this point in the history

  4. Fix different error message

    @viirya
    viirya committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    314886f View commit details
    Browse the repository at this point in the history

  5. Fix typo

    @viirya
    viirya committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    de42e04 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2022

  1. Rename APIs and add more comments. Print values in error message.

    @viirya
    viirya committed Sep 4, 2022
    Configuration menu
    Copy the full SHA
    e8218c4 View commit details
    Browse the repository at this point in the history

  2. Add one more test to distinct divide_by_zero behavior on divide.

    @viirya
    viirya committed Sep 4, 2022
    Configuration menu
    Copy the full SHA
    06f4ce3 View commit details
    Browse the repository at this point in the history

  3. Fix clippy

    @viirya
    viirya committed Sep 4, 2022
    Configuration menu
    Copy the full SHA
    4aa4432 View commit details
    Browse the repository at this point in the history

  4. Update divide doc with dividing by zero behavior for other numeric ty… 

    …pes.
    @viirya
    viirya committed Sep 4, 2022
    Configuration menu
    Copy the full SHA
    3d98aff View commit details
    Browse the repository at this point in the history

  5. Hide ArrowNativeTypeOp

    @viirya
    viirya committed Sep 4, 2022
    Configuration menu
    Copy the full SHA
    c930f85 View commit details
    Browse the repository at this point in the history

  6. Fix a typo

    @viirya
    viirya committed Sep 4, 2022
    Configuration menu
    Copy the full SHA
    34ea894 View commit details
    Browse the repository at this point in the history