Expose use_emulator option for GCS #2628
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wonder if we should instead be configuring fake-gcs to use HTTP, we could then provide an I'll have a quick play later today |
|
This is likely much better - consistent and infallible 😀. |
|
I switched away from using insecure TLS in #2632 PTAL and let me know what you think / how you would like to proceed |
|
From my perspective, your approach using http is superior, so going that way makes more sense. Given the need is only to do integration test "somehow"... |
|
Ok let's move forward with that then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2627
Rationale for this change
Currently a test-only option is exposed, to configure an unsafe client. To avoid exposing third party types in the public API, I moved the same logic as used in test behind a
use_emulatoroption.Also after some trials around copy-if-not exists, it seemed to me fake-gcs so far does not support this. fsouza/fake-gcs-server#909.
What changes are included in this PR?
New builder option for GCS object sore.
Are there any user-facing changes?
yes