Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support DictionaryArray in temporal kernels #2623

Merged
merged 7 commits into from
Sep 7, 2022
Merged

Support DictionaryArray in temporal kernels #2623

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
496c471
Support dictionary array in temporal kernels
viirya Sep 1, 2022
5171909
Support dictionary array in temporal kernels
viirya Sep 1, 2022
4f59e38
Prepare for merging conflicts
viirya Sep 1, 2022
b6c8a86
Merge remote-tracking branch 'upstream/master' into temporal_hour
viirya Sep 1, 2022
44d3a5c
Keep same kernel signature for primitive array
viirya Sep 2, 2022
29d36c7
For review
viirya Sep 6, 2022
6bf3925
Add doc
viirya Sep 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 4 additions & 4 deletions arrow/src/array/array_primitive.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ impl<'a, T: ArrowPrimitiveType> ArrayAccessor for &'a PrimitiveArray<T> {
}
}

fn as_datetime<T: ArrowPrimitiveType>(v: i64) -> Option<NaiveDateTime> {
pub(crate) fn as_datetime<T: ArrowPrimitiveType>(v: i64) -> Option<NaiveDateTime> {
match T::DATA_TYPE {
DataType::Date32 => Some(temporal_conversions::date32_to_datetime(v as i32)),
DataType::Date64 => Some(temporal_conversions::date64_to_datetime(v)),
Expand All @@ -233,7 +233,7 @@ fn as_date<T: ArrowPrimitiveType>(v: i64) -> Option<NaiveDate> {
as_datetime::<T>(v).map(|datetime| datetime.date())
}

fn as_time<T: ArrowPrimitiveType>(v: i64) -> Option<NaiveTime> {
pub(crate) fn as_time<T: ArrowPrimitiveType>(v: i64) -> Option<NaiveTime> {
match T::DATA_TYPE {
DataType::Time32(unit) => {
// safe to immediately cast to u32 as `self.value(i)` is positive i32
Expand Down Expand Up @@ -1123,13 +1123,13 @@ mod tests {
use crate::compute::hour;
let a: TimestampMicrosecondArray = vec![37800000000, 86339000000].into();

let b = hour(&a).unwrap();
let b = hour::<TimestampMicrosecondType, _>(&a).unwrap();
assert_eq!(10, b.value(0));
assert_eq!(23, b.value(1));

let a = a.with_timezone(String::from("America/Los_Angeles"));

let b = hour(&a).unwrap();
let b = hour::<TimestampMicrosecondType, _>(&a).unwrap();
assert_eq!(2, b.value(0));
assert_eq!(15, b.value(1));
}
Expand Down
2 changes: 2 additions & 0 deletions arrow/src/array/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,6 +220,8 @@ pub use self::array::make_array;
pub use self::array::new_empty_array;
pub use self::array::new_null_array;

pub(crate) use self::array_primitive::{as_datetime, as_time};

///
/// # Example: Using `collect`
/// ```
Expand Down