New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support empty projection in CSV and JSON readers #2604
Conversation
Some test failures related to the changes, will have a look later |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
arr, | ||
&RecordBatchOptions { | ||
match_field_names: true, | ||
row_count: Some(rows.len()), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
projection | ||
.as_ref() | ||
.map(|p| p.contains(field.name())) | ||
.unwrap_or(true) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Benchmark runs are scheduled for baseline = 81f1f81 and contender = 248fa30. 248fa30 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Closes #2603
Rationale for this change
What changes are included in this PR?
Support empty projection
Are there any user-facing changes?