Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

struct UnionBuilder will create child buffers with capacity #2560

Merged
merged 5 commits into from Aug 24, 2022

Conversation

kastolars
Copy link
Contributor

Which issue does this PR close?

Closes #2523.

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the arrow Changes to the arrow crate label Aug 23, 2022
@kastolars kastolars changed the title UnionBuilder Create Children With Capacity struct UnionBuilder will create child buffers with capacity Aug 23, 2022
@tustvold
Copy link
Contributor

Cargo fmt wants a comma...

@kastolars
Copy link
Contributor Author

Cargo fmt wants a comma...

Okay I added the commas. I'm not sure if there's a tool or intellij plugin where I can auto-format per those standards but I'll look it up.

@tustvold
Copy link
Contributor

tustvold commented Aug 23, 2022

If you are using the Intellij-rust plugin, if you go to settings you can set it to use rustfmt instead of the built-in formatter.

You can also just run cargo fmt -all before pushing

@tustvold tustvold merged commit 87290ff into apache:master Aug 24, 2022
@ursabot
Copy link

ursabot commented Aug 24, 2022

Benchmark runs are scheduled for baseline = d36f072 and contender = 87290ff. 87290ff is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UnionBuilder Create Children With Capacity
3 participants