Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compare dictionary array and primitive array in lt_dyn, lt_eq_dyn, gt_dyn, gt_eq_dyn kernels #2539

Merged
merged 1 commit into from Aug 21, 2022
Merged

Compare dictionary array and primitive array in lt_dyn, lt_eq_dyn, gt_dyn, gt_eq_dyn kernels #2539

merged 1 commit into from Aug 21, 2022

Conversation

viirya
Copy link
Member

@viirya viirya commented Aug 20, 2022

Which issue does this PR close?

Closes #2538.

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@viirya viirya changed the title Compare dictionary array and non-dictionary array in lt_dyn, lt_eq_dyn, gt_dyn, gt_eq_dyn kernels Compare dictionary array and primitive array in lt_dyn, lt_eq_dyn, gt_dyn, gt_eq_dyn kernels Aug 20, 2022
@github-actions github-actions bot added the arrow Changes to the arrow crate label Aug 20, 2022
viirya
viirya commented Aug 20, 2022
View reviewed changes
arrow/src/compute/kernels/comparison.rs
let values = Int8Array::from_iter_values([10_i8, 11, 12, 13, 14, 15, 16, 17]);
let keys = Int8Array::from_iter_values([2_i8, 3, 4]);

let dict_array = DictionaryArray::try_new(&keys, &values).unwrap();
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[12, 13, 14]

viirya
viirya commented Aug 20, 2022
View reviewed changes
arrow/src/compute/kernels/comparison.rs

let dict_array = DictionaryArray::try_new(&keys, &values).unwrap();

let array = Int8Array::from_iter([Some(12_i8), None, Some(11)]);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[12, null, 11]

@viirya viirya merged commit de7ad62 into apache:master Aug 21, 2022
@ursabot
Copy link

ursabot commented Aug 21, 2022

Benchmark runs are scheduled for baseline = cd1c174 and contender = de7ad62. de7ad62 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jimexist Jimexist Jimexist approved these changes

Assignees
No one assigned
Labels
arrow Changes to the arrow crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compare dictionary with primitive array in lt_dyn, lt_eq_dyn, gt_dyn, gt_eq_dyn
3 participants
@viirya @ursabot @Jimexist