Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve performance of %pat% (>3x speedup) #2521

Merged
merged 2 commits into from Aug 19, 2022
Merged

Improve performance of %pat% (>3x speedup) #2521

merged 2 commits into from Aug 19, 2022

Conversation

Dandandan
Copy link
Contributor

Which issue does this PR close?

Closes #2519

Rationale for this change

LIKE %pat% is something that occurs a lot in SQL queries. It's also one of the slower queries in the ClickBench benchmarks.

Results:

like_utf8 scalar contains                        
                        time:   [1.9803 ms 1.9828 ms 1.9853 ms]
                        change: [-71.755% -71.321% -70.997%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 3 outliers among 100 measurements (3.00%)
  1 (1.00%) low mild
  2 (2.00%) high mild

Benchmarking nlike_utf8 scalar contains: Warming up for 3.0000 s
Warning: Unable to complete 100 samples in 5.0s. You may wish to increase target time to 9.9s, enable flat sampling, or reduce sample count to 40.
Benchmarking nlike_utf8 scalar contains: Collecting 100 samples in estimated 9.9                                                                                nlike_utf8 scalar contains                        
                        time:   [1.9413 ms 1.9448 ms 1.9488 ms]
                        change: [-71.544% -71.455% -71.344%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 10 outliers among 100 measurements (10.00%)
  1 (1.00%) low mild
  6 (6.00%) high mild
  3 (3.00%) high severe

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the arrow Changes to the arrow crate label Aug 19, 2022
@tustvold
Copy link
Contributor

Very nice 👍

@tustvold tustvold merged commit e80f647 into apache:master Aug 19, 2022
@ursabot
Copy link

ursabot commented Aug 19, 2022

Benchmark runs are scheduled for baseline = b3fd4bd and contender = e80f647. e80f647 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

amrltqt pushed a commit to amrltqt/arrow-rs that referenced this pull request Aug 20, 2022
@Dandandan @amrltqt
Improve performance of %pat% (>3x speedup) (apache#2521)
da22f0d 
* Special case contains

* Fix
jhorstmann
jhorstmann reviewed Aug 21, 2022
View reviewed changes
arrow/src/compute/kernels/comparison.rs
for i in 0..left.len() {
if left.value(i).ends_with(ends_with) {
bit_util::set_bit(bool_slice, i);
}
}
} else if right.starts_with('%')
&& right.ends_with('%')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

like supports escape characters now (#2258), so I think this also needs to check that the string does not end with '\%'

@Dandandan Dandandan mentioned this pull request Sep 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhorstmann jhorstmann jhorstmann left review comments

@tustvold tustvold tustvold approved these changes

Assignees
No one assigned
Labels
arrow Changes to the arrow crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Speed up like_utf8_scalar for %pat%
4 participants
@Dandandan @tustvold @ursabot @jhorstmann