Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in page skipping #2504

Merged
merged 1 commit into from Aug 18, 2022
Merged

Fix bug in page skipping #2504

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions parquet/src/file/serialized_reader.rs
View file
Open in desktop
Expand Up @@ -730,6 +730,7 @@ impl<R: ChunkReader> PageReader for SerializedPageReader<R> {
if let Some(buffered_header) = next_page_header.take() {
// The next page header has already been peeked, so just advance the offset
*offset += buffered_header.compressed_page_size as usize;
*remaining_bytes -= buffered_header.compressed_page_size as usize;
} else {
let mut read =
self.reader.get_read(*offset as u64, *remaining_bytes)?;
Expand Down Expand Up @@ -1556,6 +1557,7 @@ mod tests {
if i % 2 == 0 {
vec.push(column_page_reader.get_next_page().unwrap().unwrap());
} else {
column_page_reader.peek_next_page().unwrap().unwrap();
column_page_reader.skip_next_page().unwrap();
}
}
Expand Down