Fallback for skip_page/peek_page without OffsetIndex in SerializedPag… #2490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thinkharderdev
commented
Aug 17, 2022
| @@ -119,6 +119,7 @@ impl RowSelection { | |||
| } | |||
|
|
|||
| /// Given an offset index, return the offset ranges for all data pages selected by `self` | |||
| #[allow(unused)] | |||
There was a problem hiding this comment.
Clippy was unhappy because this method is only used with the async feature
thinkharderdev
commented
Aug 17, 2022
| @@ -484,13 +484,17 @@ pub(crate) fn decode_page( | |||
| Ok(result) | |||
| } | |||
|
|
|||
| #[allow(clippy::large_enum_variant)] | |||
There was a problem hiding this comment.
Boxing buffered_header seemed counterproductive here so I just disabled the lint warning
|
I believe @Ted-Jiang is already working on this in #2460... Perhaps we could keep some of the tests from this? |
Ah, sorry about that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…eReader
Which issue does this PR close?
Closes #2459
Closes #2434
Rationale for this change
Need to be able to peek/skip pages even if we do not have an OffsetIndex
What changes are included in this PR?
Implement
skip_next_pageandpeek_next_pageinSerializedPageReaderAre there any user-facing changes?